fix(mysql-cdc): enable heartbeat message to keep the offset up to date with upstream #12868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
requested review from
liurenjie1024,
hzxa21,
tabVersion and
BugenZhao
StrikeW
force-pushed
the
siyuan/cdc-binlog-retention
branch
from
921142b to
014b2ab
Compare
tabVersion
approved these changes
Oct 16, 2023
...isingwave-connector-test/src/test/java/com/risingwave/connector/source/SourceTestClient.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #12868 +/- ##
==========================================
+ Coverage 69.14% 69.25% +0.11%
==========================================
Files 1487 1489 +2
Lines 244648 245828 +1180
==========================================
+ Hits 169150 170246 +1096
- Misses 75498 75582 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
…e with upstream (#12868)
lmatz
pushed a commit
that referenced
this pull request
Oct 17, 2023
…e with upstream (#12868) (#12886) Co-authored-by: StrikeW <[email protected]>
BugenZhao
reviewed
Oct 17, 2023
Comment on lines
+534
to
+536
| split_offset_mapping | ||
| .entry(msg.split_id) | ||
| .or_insert(msg.offset.clone()); |
There was a problem hiding this comment.
I guess this should apply to all kinds of messages that have empty keys and payloads? 🤔
There was a problem hiding this comment.
I expect this patch only affect direct cdc use cases, because I am not sure when it would break other connectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Enable Debezium to emit heartbeat message which contains a binlog offset for each
heartbeat.interval.ms, so that the persisted source offset can be updated even though the upstream table doesn't have any update for a long time.Tested locally.
related: #12753
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.